Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix successUrl -> successUri. #333

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix successUrl -> successUri. #333

merged 1 commit into from
Jul 17, 2023

Conversation

guidorice
Copy link
Contributor

@guidorice guidorice commented Jul 13, 2023

This PR fixes the naming of a required property on the subscriber schema.

@guidorice guidorice marked this pull request as ready for review July 13, 2023 18:43
@pvretano pvretano merged commit 364dd81 into opengeospatial:master Jul 17, 2023
1 check passed
@jerstlouis
Copy link
Member

@pvretano Is this only a typo fix, or could this potentially be a breaking change?

The OGC API - Processes - Part 1: Core standard also seems very light on actual requirement for this callback functionality.

It references https://swagger.io/docs/specification/callbacks/ which does include a successUrl with an L (URL).

@gfenoy
Copy link
Contributor

gfenoy commented Jul 17, 2023

I think that the issue comes from the current schema located here: https://schemas.opengis.net/ogcapi/processes/part1/1.0/openapi/schemas/subscriber.yaml

It mentions that the required value is one which is not available successUrl when successUri is defined as one possible option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants